Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e tests] Wait for secondary IPs before running ping test #6041

Merged

Conversation

antoninbas
Copy link
Contributor

@antoninbas antoninbas commented Mar 1, 2024

For VLAN Secondary Network e2e tests, we need to wait for secondary IPs to be available. Interface creation can take up to a few seconds after the Pod is in the Running state, as it happens asynchronously. Otherwise we can get the following error:

secondary_network_test.go:194: Error when pinging between interfaces: interface eth1 not found on vlan-pod2. err: <nil>

Fixes #6023

@antoninbas antoninbas requested a review from jianjuns March 1, 2024 03:09
@antoninbas antoninbas added area/test/e2e Issues or PRs related to Antrea specific end-to-end testing. area/secondary-network Issues or PRs related to support for secondary networks in Antrea labels Mar 1, 2024
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

test/e2e-secondary-network/secondary_network_test.go Outdated Show resolved Hide resolved
test/e2e-secondary-network/secondary_network_test.go Outdated Show resolved Hide resolved
For VLAN Secondary Network e2e tests, we need to wait for secondary IPs
to be available. Interface creation can take up to a few seconds after
the Pod is in the Running state, as it happens asynchronously. Otherwise
we can get the following error:

secondary_network_test.go:194: Error when pinging between interfaces: interface eth1 not found on vlan-pod2. err: <nil>

Fixes antrea-io#6023

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas force-pushed the wait-for-secondary-ips-to-run-ping-test branch from 41d0113 to 98d8255 Compare March 1, 2024 17:19
Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas requested a review from jianjuns March 1, 2024 17:59
@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas antoninbas merged commit 393d186 into antrea-io:main Mar 1, 2024
52 of 55 checks passed
@antoninbas antoninbas deleted the wait-for-secondary-ips-to-run-ping-test branch March 1, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/secondary-network Issues or PRs related to support for secondary networks in Antrea area/test/e2e Issues or PRs related to Antrea specific end-to-end testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky test] TestVLANNetwork failing
2 participants